Permutation of a String #11769
Permutation of a String #11769
Conversation
for more information, see https://pre-commit.ci
Added a new code
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class Solution: | ||
| def checkInclusion(self, s1: str, s2: str) -> bool: |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: checkInclusion
As there is no test file in this pull request nor any test function or class in the file strings/Permutation_in_String.py, please provide doctest for the function checkInclusion
| from collections import Counter | ||
|
|
||
| class Solution: | ||
| def check_inclusion(self, s1: str, s2: str) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file strings/permutation_in_string.py, please provide doctest for the function check_inclusion
for more information, see https://pre-commit.ci
|
Closing tests_are_failing PRs to prepare for Hacktoberfest |
Check whether the permutation of string 2 in string 1